netdev - Re: [PATCH] [2.6.26] [CAN] Fix can_send() handling on dev_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080508.025044.124227730.davem@davemloft.net>
Date:	Thu, 08 May 2008 02:50:44 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	oliver@...tkopp.net
Cc:	urs@...ogud.escape.de, nautsch@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] [2.6.26] [CAN] Fix can_send() handling on
 dev_queue_xmit() failures

From: Oliver Hartkopp <oliver@...tkopp.net>
Date: Tue, 06 May 2008 21:49:57 +0200

> The tx packet counting and the local loopback of CAN frames should
> only happen in the case that the CAN frame has been enqueued to the
> netdevice tx queue successfully.
> 
> Thanks to Andre Naujoks <nautsch@...il.com> for reporting this issue.
> 
> Signed-off-by: Oliver Hartkopp <oliver@...tkopp.net>
> Signed-off-by: Urs Thuermann <urs@...ogud.escape.de>

Applied, thanks Oliver.

> this patch should go into 2.6.26 and also applies fine on 2.6.25.1.
> 
> IMO this issue is not that 'critical' that it *requires* to become
> part of 2.6.25.2. Please forward the patch to Greg at your own opinion.

I think I'll push it to -stable, thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html