netdev - Re: [RFC/RFT 2/4] GSO: generalize for mac80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1210090363.3914.13.camel@johannes.berg>
Date:	Tue, 06 May 2008 18:12:43 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	linux-wireless@...r.kernel.org
Cc:	netdev@...r.kernel.org, Ron Rindjunsky <ron.rindjunsky@...el.com>,
	Tomas Winkler <tomasw@...il.com>,
	Ivo van Doorn <ivdoorn@...il.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [RFC/RFT 2/4] GSO: generalize for mac80211

On Wed, 2008-04-30 at 14:40 +0200, Johannes Berg wrote:
> plain text document attachment (037-generalize-gso-functions.patch)
> This patch adds a new function dev_skb_segment() that generalises
> the existing dev_gso_segment() by allowing to give a segmentation
> function. mac80211 will use that function using the segmentation
> function skb_segment().
> 
> This patch also changes dev_gso_skb_destructor() to be safe when
> the skb no longer has any segments, this will happen when mac80211
> has internally passed off all the fragments to the driver instead
> of asking dev_hard_start_xmit() to do it (which protects against
> this by resetting the destructor if it has sent all fragments.)

Any comments on this? I'd like to include this (well, more importantly
the mac80211 patch that needs it) for testing for 2.6.27, should I send
it via John or directly to you, Dave?

Also, I'm not sure, should I allow for a segmentation function at all?
I'm only going to use the generic skb_segment and the code there only
uses skb_gso_segment.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)