netdev - Re: [RFC/RFT 3/4] mac80211: use GSO for fragmentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080507071026.GA24407@gondor.apana.org.au>
Date:	Wed, 7 May 2008 15:10:26 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	Ron Rindjunsky <ron.rindjunsky@...el.com>,
	Tomas Winkler <tomasw@...il.com>,
	Ivo van Doorn <ivdoorn@...il.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
Subject: Re: [RFC/RFT 3/4] mac80211: use GSO for fragmentation

On Wed, Apr 30, 2008 at 02:40:58PM +0200, Johannes Berg wrote:
> This patch makes mac80211 use the GSO infrastructure for segmentation,
> but not really all of it because we do not register a protocol handler
> (nor can do that easily since a lot of functions need to be done before
> segmentation and another bunch afterwards, and we need to keep rcu-
> protected structures for both.)

Your idea of using skb_segment to remove duplicate code is great.

However, using skb->gso_skb for the push-back doesn't work.  For
example, what is going to happen when I enable software GSO on a
wireless device and then send a real GSO packet to it where each
GSO fragment also required wireless fragmentation?

I suggest that you just use skb_segment for the actual fragmentation
but keep the original infrastructure for handling the fragments.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html