netdev - Re: [PATCH 06/13] QLogic VNIC: IB core stack interaction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adafxsmj5t7.fsf@cisco.com>
Date:	Tue, 13 May 2008 13:40:52 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Ramachandra K <ramachandra.kuchimanchi@...gic.com>
Cc:	general@...ts.openfabrics.org, netdev@...r.kernel.org,
	amar.mudrankit@...gic.com, poornima.kamath@...gic.com
Subject: Re: [PATCH 06/13] QLogic VNIC: IB core stack interaction

 > +#include <rdma/ib_cache.h>

 > +	ret = ib_find_cached_pkey(viport_config->ibdev,
 > +				  viport_config->port,
 > +				  be16_to_cpu(viport_config->path_info.path.
 > +					      pkey),
 > +				  &attr->pkey_index);

I think this can just be replaced with ib_find_pkey()... there is a call
to kmalloc(... GFP_KERNEL) just a couple of lines about, so you are in a
context where sleeping is allowed.  As I said before we want to get rid
of the caching infrastructure so please don't add new users.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html