netdev - Re: [PATCH 12/13] QLogic VNIC: Driver Kconfig and Makefile.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adafxsjdwro.fsf@cisco.com>
Date:	Thu, 15 May 2008 15:31:55 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Ramachandra K <ramachandra.kuchimanchi@...gic.com>
Cc:	general@...ts.openfabrics.org, netdev@...r.kernel.org,
	amar.mudrankit@...gic.com, poornima.kamath@...gic.com
Subject: Re: [PATCH 12/13] QLogic VNIC: Driver Kconfig and Makefile.

 > +config INFINIBAND_QLGC_VNIC_DEBUG
 > +	bool "QLogic VNIC Verbose debugging"
 > +	depends on INFINIBAND_QLGC_VNIC
 > +	default n
 > +	---help---
 > +	  This option causes verbose debugging code to be compiled
 > +	  into the QLogic VNIC driver.  The output can be turned on via the
 > +	  vnic_debug module parameter.

If you have runtime control of this, I suggest making it default to on,
like mthca does with:

	config INFINIBAND_MTHCA_DEBUG
		bool "Verbose debugging output" if EMBEDDED
		depends on INFINIBAND_MTHCA
		default y

otherwise distros will leave the option off and it becomes a pain to
debug problems because you force users to do compiles.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html