lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 May 2008 22:51:23 +0200 From: Florian Fainelli <florian.fainelli@...ecomint.eu> To: Anton Vorontsov <avorontsov@...mvista.com> Cc: Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org Subject: Re: [PATCH] [NET] uli526x: add support for netpoll Hello Anton, Le Thursday 15 May 2008 17:12:55 Anton Vorontsov, vous avez écrit : > +#ifdef CONFIG_NET_POLL_CONTROLLER > +static void uli526x_poll(struct net_device *dev) > +{ > + /* ISR grabs the irqsave lock, so this should be safe */ > + uli526x_interrupt(dev->irq, dev); > +} > +#endif You do not need to wrap this function into the ifdef, since setting the poll callback is between ifdef. Otherwise patch looks good. -- Cordialement, Florian Fainelli ------------------------------ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists