netdev - Re: [PATCH] [NET] uli526x: add support for netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080516111349.GA27587@polina.dev.rtsoft.ru>
Date:	Fri, 16 May 2008 15:13:49 +0400
From:	Anton Vorontsov <avorontsov@...mvista.com>
To:	Florian Fainelli <florian.fainelli@...ecomint.eu>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] [NET] uli526x: add support for netpoll

On Thu, May 15, 2008 at 10:51:23PM +0200, Florian Fainelli wrote:
> Hello Anton,
> 
> Le Thursday 15 May 2008 17:12:55 Anton Vorontsov, vous avez écrit :
> > +#ifdef CONFIG_NET_POLL_CONTROLLER
> > +static void uli526x_poll(struct net_device *dev)
> > +{
> > +	/* ISR grabs the irqsave lock, so this should be safe */
> > +	uli526x_interrupt(dev->irq, dev);
> > +}
> > +#endif
> 
> You do not need to wrap this function into the ifdef, since setting the poll 
> callback is between ifdef. Otherwise patch looks good.

Nope, I need this #ifdef, otherwise gcc will warn about unused function
if netpoll is not selected.

Of course, I could do __maybe_unused, but #ifdef is what most (all?)
drivers are doing.

-- 
Anton Vorontsov
email: cbouatmailru@...il.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html