netdev - Re: natsemi.c ioctl fix or mii register access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080516205705.GA19586@electric-eye.fr.zoreil.com>
Date:	Fri, 16 May 2008 22:57:05 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	glenn_engel@...lent.com
Cc:	netdev@...r.kernel.org, jgarzik@...ox.com
Subject: Re: natsemi.c ioctl fix or mii register access

(please shorten your lines below 80 cols)

glenn_engel@...lent.com <glenn_engel@...lent.com> :
[...]
> The specific problems noted and fixed:
> 
> 1. The if_mii macro casts it's return to be (struct mii_ioctl_data *) but
> in reality it returns a pointer to the user space pointer (struct
> mii_ioctl_data**).   This looks to be a problem with the mii_macro to me.
> I changed this to use the ifr_data macro instead.

Which user space application did you read the source of ?

Afaiks the kernel side looks very similar to any usual network device
driver ioctl.

> 2. Since the mii_ioctl_data structure resides in user space, it must be
> copied into kernel space before access and copied back for read results.

Is not it what net/core/dev.c::dev_ioctl does.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html