netdev - Re: [PATCH net-next 1/6] [BNX2]: Allow phy reset to be skipped during chip reset.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080516213430.GC20212@gospo.usersys.redhat.com>
Date:	Fri, 16 May 2008 17:34:30 -0400
From:	Andy Gospodarek <andy@...yhouse.net>
To:	Michael Chan <mchan@...adcom.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, andy@...yhouse.net,
	benli@...adcom.com
Subject: Re: [PATCH net-next 1/6] [BNX2]: Allow phy reset to be skipped during chip reset.

On Fri, May 16, 2008 at 02:29:36PM -0700, Michael Chan wrote:
> [BNX2]: Allow phy reset to be skipped during chip reset.
> 
> Andy Gospodarek <andy@...yhouse.net> found that netconsole would
> panic when resetting bnx2 devices.
> 
> >From Andy:
> "The issue is the bnx2_set_link in bnx2_init_nic will print a link-status
> message before we are fully initialized and ready to start polling.
> Polling is currently disabled in this state, but since the
> __LINK_STATE_RX_SCHED is overloaded to not only try and disable polling
> but also to make the system aware there is something waiting to be
> polled, we really have to fix this in drivers.
> 
> The problematic call is the one to netif_rx_complete as it tries to
> remove an entry from the poll_list when there isn't one."
> 
> While this netconsole problem should be fixed separately, we really
> should not reset the PHY when changing ring sizes, MTU, or other
> similar settings.  The PHY reset causes several seconds of unnecessary
> link disruptions.
> 
> Signed-off-by: Michael Chan <mchan@...adcom.com>
> Cc: Andy Gospodarek <andy@...yhouse.net>

Acked-by: Andy Gospodarek <andy@...yhouse.net>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html