netdev - Re: [PATCH] PHYLIB: Add 1000Base-X support for Broadcom bcm5482

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.55.0805170607190.4049@cliff.in.clinika.pl>
Date:	Sat, 17 May 2008 06:18:46 +0100 (BST)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Nate Case <ncase@...-inc.com>
cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] PHYLIB: Add 1000Base-X support for Broadcom bcm5482

On Thu, 15 May 2008, Nate Case wrote:

> Fixed this in patch v3 (coming up shortly).

 This one works for me as well.  However I have noticed a couple of
unnecessary "inline" annotations.  I think it is best to leave the
decision about inlining up to the compiler -- remember that for Linux
"inline" expands to "inline __attribute__((always_inline))".  I have
updated the patch on your behalf to save you the hassle with another
iteration and will send it separately straight away, together with a few
trivial formatting adjustments.  Let me know if you disagree with any of
these changes.

 While doing this I have checked the relevant Kconfig file and noticed the 
new PHY models are not mentioned -- I will send another patch separately.

> I didn't try forcing speeds from userspace, but the worst I can envision
> happening is that after forcing 10mbit/s or half-duplex mode (for
> example) it would still report 1000mbit/s FD.  The forcing itself would
> probably not report an error, though you could argue that it should.  My
> understanding is that the hardware will take the writes but ignore those
> registers in 1000Base-X mode.

 Please try when you have some opportunity.  Personally I think an error
is not strictly necessary as long as the status read back is correct.

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html