netdev - Re: [PATCH?] Fix call to ->change_rx_flags(dev, IFF_MULTICAST) in dev_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 May 2008 14:47:32 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	David Woodhouse <dwmw2@...radead.org>
CC:	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH?] Fix call to ->change_rx_flags(dev, IFF_MULTICAST) in
 dev_change_flags()

David Woodhouse wrote:
> Am I just being particularly dim today, or can the call to
> dev->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags() never
> happen?
> 
> We've just set dev->flags = flags & IFF_MULTICAST, effectively. So the
> condition '(dev->flags ^ flags) & IFF_MULTICAST' is _never_ going to be
> true.

Thanks for catching this, you're correct of course.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html