[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20080520.143641.122144468.davem@davemloft.net>
Date: Tue, 20 May 2008 14:36:41 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: kaber@...sh.net
Cc: dwmw2@...radead.org, netdev@...r.kernel.org
Subject: Re: [PATCH?] Fix call to ->change_rx_flags(dev, IFF_MULTICAST) in
dev_change_flags()
From: Patrick McHardy <kaber@...sh.net>
Date: Tue, 20 May 2008 14:47:32 +0200
> David Woodhouse wrote:
> > Am I just being particularly dim today, or can the call to
> > dev->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags() never
> > happen?
> >
> > We've just set dev->flags = flags & IFF_MULTICAST, effectively. So the
> > condition '(dev->flags ^ flags) & IFF_MULTICAST' is _never_ going to be
> > true.
>
> Thanks for catching this, you're correct of course.
Applied and queued to -stable, thanks everyone!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists