lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080520152405.GC2067@elf.ucw.cz>
Date:	Tue, 20 May 2008 17:24:06 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	akpm@...ux-foundation.org, hidave.darkstar@...il.com,
	linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [patch 2/3] hci_usb: remove code obfuscation

Hi!

>> There needs to be some load on the usb. I use
>> rsync-over-bt-over-gprs/umts.
>
> you told me before and I believe you. This driver is not in its best shape. 
> Weird thing is that I never got it re-produced. If you find the real cause. 
> That would be great.

The cause seems to be hci_usb_close() racing with the USB core and
completion handlers...

>>>> It could be easily fixed by just not freeing the urbs during
>>>> disconnect (introducing very very slow memory leak). Would that be
>>>> acceptable?
>>>
>>> I don't think so.
>>>
>>> Have you ever tried btusb driver? That code is a lot cleaner and it uses
>>> USB anchors for the queued URBs (no home grown broken URB queues).
>>
>> I wish I knew about  this one earlier. Yes, it seems to work for me.
>
> Does this mean you are not fixing hci_usb anymore ;)

I'm not sure what's next, as hci_usb is still in opensuse11...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ