netdev - Re: [patch 2/3] hci_usb: remove code obfuscation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 May 2008 19:26:42 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Pavel Machek <pavel@...e.cz>
Cc:	akpm@...ux-foundation.org, hidave.darkstar@...il.com,
	linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [patch 2/3] hci_usb: remove code obfuscation

Hi Pavel,

>>> There needs to be some load on the usb. I use
>>> rsync-over-bt-over-gprs/umts.
>>
>> you told me before and I believe you. This driver is not in its  
>> best shape.
>> Weird thing is that I never got it re-produced. If you find the  
>> real cause.
>> That would be great.
>
> The cause seems to be hci_usb_close() racing with the USB core and
> completion handlers...
>
>>>>> It could be easily fixed by just not freeing the urbs during
>>>>> disconnect (introducing very very slow memory leak). Would that be
>>>>> acceptable?
>>>>
>>>> I don't think so.
>>>>
>>>> Have you ever tried btusb driver? That code is a lot cleaner and  
>>>> it uses
>>>> USB anchors for the queued URBs (no home grown broken URB queues).
>>>
>>> I wish I knew about  this one earlier. Yes, it seems to work for me.
>>
>> Does this mean you are not fixing hci_usb anymore ;)
>
> I'm not sure what's next, as hci_usb is still in opensuse11...

the goal should be improve btusb. Especially add all the needed quirks  
from the hci_usb driver to it. I have a patch for it, but I need to  
reverse the HCI_RESET logic.

However if you have hci_usb patches, send them, I will review them and  
David will happily apply them I guess.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html