lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 22 May 2008 14:45:23 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Thomas Graf <tgraf@...g.ch>
CC:	davem@...emloft.net, Stephen Hemminger <shemminger@...tta.com>,
	Dave Jones <davej@...emonkey.org.uk>, netdev@...r.kernel.org
Subject: Re: [NETLINK]: Fix nla_parse_nested_compat() to call nla_parse()
 directly

Thomas Graf wrote:
> The purpose of nla_parse_nested_compat() is to parse attributes
> which contain a struct followed by a stream of nested attributes.
> So far, it called nla_parse_nested() to parse the stream of
> nested attributes which was wrong, as nla_parse_nested() expects
> a container attribute as data which holds the attribute stream.
> It needs to call nla_parse() directly while pointing at the
> next possible alignment point after the struct in the beginning
> of the attribute.
>
> With this patch, I can no longer reproduce the reported leftover
> warnings.
>
> Signed-off-by: Thomas Graf <tgraf@...g.ch>

Looks good to me, thanks for fixing this Thomas.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists