netdev - Re: Fwd: [Bug 447812] New: Netlink messages from "tc" to sch_netem module are not interpreted correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4835A00E.2050908@hp.com>
Date:	Thu, 22 May 2008 09:32:14 -0700
From:	Rick Jones <rick.jones2@...com>
To:	Thomas Graf <tgraf@...g.ch>
CC:	Stephen Hemminger <shemminger@...tta.com>,
	Dave Jones <davej@...emonkey.org.uk>, netdev@...r.kernel.org
Subject: Re: Fwd: [Bug 447812] New: Netlink messages from "tc" to sch_netem
 module are not interpreted correctly

> I looked at netrt_rtnetlink.c, the problem is unrelated. Look at
> the code when adding the source attribtue:
> 
>   struct rtattr *rtap;
> 
>   if (source) {
>     rtap +=  rtap->rta_len;
> 
> You want to increment rtap by rta_len bytes, not rta_len*sizeof(*rtap)
> bytes.
> 
> Also, the code uses RTA_LENGTH() to calculate attributes sizes which
> is wrong, it must use RTA_SPACE() as RTA_LENGTH() does not align the
> actual data part and thus the next attribute is unaligned if the data
> of the previous attribute is not aligned to 4 bytes.

I'll make the fixes in the netperf code - thanks, hope the bugs there 
weren't too big a distraction.

rick jones

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html