netdev - Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1211915874.18326.101.camel@dell>
Date:	Tue, 27 May 2008 12:17:54 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Roland Dreier" <rdreier@...co.com>
cc:	"Anil Veerabhadrappa" <anilgv@...adcom.com>,
	"David Miller" <davem@...emloft.net>, michaelc@...wisc.edu,
	netdev <netdev@...r.kernel.org>, linux-scsi@...r.kernel.org,
	open-iscsi@...glegroups.com
Subject: Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver.

On Tue, 2008-05-27 at 07:38 -0700, Roland Dreier wrote:
>  > 'bnx2id' is the user component in this solution. bnx2id daemon uses
>  > socket calls to bind tcp ports in high range and hands them over to
>  > driver. This is how iscsi driver tries to solve tcp port collision
>  > issue. User daemon communicates with the driver using sysfs and tcp port
>  > related functions are bnx2i_read_tcp_portd_*/bnx2i_write_tcp_portd_*
>  > (reference: bnx2i_sysfs.c)
> 
> So you are creating sockets just to reserve TCP ports to avoid host
> stack clashes with your offload engine?  Wasn't this approach strongly
> rejected (in the context of iWARP) in the past?
> 

We're doing it in userspace, so I don't if that makes it any better or
any worse.

Roland, what do you suggest?  We can do it like cma_alloc_any_port() in
cma.c.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html