netdev - Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adaabibvc9f.fsf@cisco.com>
Date:	Tue, 27 May 2008 11:21:32 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	"Michael Chan" <mchan@...adcom.com>
Cc:	"Anil Veerabhadrappa" <anilgv@...adcom.com>,
	"David Miller" <davem@...emloft.net>, michaelc@...wisc.edu,
	netdev <netdev@...r.kernel.org>, linux-scsi@...r.kernel.org,
	open-iscsi@...glegroups.com
Subject: Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver.

 > We're doing it in userspace, so I don't if that makes it any better or
 > any worse.

How do you do it in userspace?  With a bind()?  That is a little
wasteful in that you are reserving a local addr/port when all you really
need to reserve is the actual local/remote 4-tuple that you are going to
use for the connection, but that's not horrible.

 > Roland, what do you suggest?  We can do it like cma_alloc_any_port() in
 > cma.c.

Actually cma.c still has the problem of host/offload port space collisions.

The whole port sharing thing is a mess -- I was hoping you had come up
with a good solution that cma.c could steal to be honest, so I don't
have any better ideas at the moment.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html