netdev - Re: race in skb_splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <483DBA0D.8090402@gmail.com>
Date:	Wed, 28 May 2008 22:01:17 +0200
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Octavian Purdila <opurdila@...acom.com>
CC:	Evgeniy Polyakov <johnpol@....mipt.ru>,
	Ben Hutchings <bhutchings@...arflare.com>,
	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: race in skb_splice_bits?

Octavian Purdila wrote, On 05/28/2008 08:02 PM:

> On Wednesday 28 May 2008, Evgeniy Polyakov wrote:
> 
>> We queue data under the lock and clone appropriate skb (and then grab it
>> multiple times), so even it will be dropped, its data will not freed, and
>> thus we will be able to read it. Or you are talking about different
>> skbs?
> 
> You are right, I forgot about the clone.
> 

Probably I miss something, but how does it help when tcp_collapse()
uses __kfree_skb()?

Regards,
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html