netdev - Re: [PATCH v2 03/13] QLogic VNIC: Implementation of communication protocol with EVIC/VEx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adaod6rq9o1.fsf@cisco.com>
Date:	Tue, 27 May 2008 22:28:46 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Ramachandra K <ramachandra.kuchimanchi@...gic.com>
Cc:	general@...ts.openfabrics.org, netdev@...r.kernel.org,
	amar.mudrankit@...gic.com, poornima.kamath@...gic.com
Subject: Re: [PATCH v2 03/13] QLogic VNIC: Implementation of communication protocol with EVIC/VEx

 > +void viport_disconnect(struct viport *viport)
 > +{
 > +	VIPORT_FUNCTION("viport_disconnect()\n");
 > +	viport->disconnect = 1;
 > +	viport_failure(viport);
 > +	wait_event(viport->disconnect_queue, viport->disconnect == 0);
 > +}
 > +
 > +void viport_free(struct viport *viport)
 > +{
 > +	VIPORT_FUNCTION("viport_free()\n");
 > +	viport_disconnect(viport);	/* NOTE: this can sleep */

There are no other calls to viport_disconnect() that I can see, so it
can be made static (and the declaration in vnic_viport.h can be dropped).
in fact given how small the function is and the fact that it has only a
single call site, it might be easier just to merge it into
viport_free().  But that's a matter of taste.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html