lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 Jun 2008 09:40:15 +1000 (EST) From: James Morris <jmorris@...ei.org> To: Adam Langley <agl@...erialviolet.org> cc: davem@...emloft.net, netdev@...r.kernel.org Subject: Re: [PATCH] Fix corrupt TCP packets when options space overflows with MD5SIG enabled On Sat, 31 May 2008, Adam Langley wrote: > When MD5 signatures are turned on we can end up with syntactically invalid > packets with a header length < 20 bytes. This is because tcp_header_size > overflows with 12 bytes of timestamp, 20 bytes of signature and > 8 bytes of > SACK option. > > Since we can't fit any SACK blocks in the final 8 bytes of options space, and > the MD5 signature is more important, we disable including SACK, or even > advertising it, when MD5 is enabled. > > Signed-off-by: Adam Langley <agl@...erialviolet.org> Reviewed-by: James Morris <jmorris@...ei.org> (FYI, the upcoming replacement for this, TCP-AO, is designed to be SACK compatible) -- James Morris <jmorris@...ei.org> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists