netdev - Re: [PATCH] Fix corrupt TCP packets when options space overflows with MD5SIG enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080601.235649.109450540.davem@davemloft.net>
Date:	Sun, 01 Jun 2008 23:56:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jmorris@...ei.org
Cc:	agl@...erialviolet.org, netdev@...r.kernel.org
Subject: Re: [PATCH] Fix corrupt TCP packets when options space overflows
 with MD5SIG enabled

From: James Morris <jmorris@...ei.org>
Date: Mon, 2 Jun 2008 09:40:15 +1000 (EST)

> On Sat, 31 May 2008, Adam Langley wrote:
> 
> > When MD5 signatures are turned on we can end up with syntactically invalid
> > packets with a header length < 20 bytes. This is because tcp_header_size
> > overflows with 12 bytes of timestamp, 20 bytes of signature and > 8 bytes of
> > SACK option.
> > 
> > Since we can't fit any SACK blocks in the final 8 bytes of options space, and
> > the MD5 signature is more important, we disable including SACK, or even
> > advertising it, when MD5 is enabled.
> > 
> > Signed-off-by: Adam Langley <agl@...erialviolet.org>
> 
> Reviewed-by: James Morris <jmorris@...ei.org>

After making some minor coding style fixups, I applied this
fix, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html