netdev - Re: [ofa-general] Re: [PATCH v3 08/13] QLogic VNIC: sysfs interface implementation for the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20080603183039.GA30454@kroah.com>
Date:	Tue, 3 Jun 2008 11:30:39 -0700
From:	Greg KH <greg@...ah.com>
To:	Amar Mudrankit <amar.mudrankit@...gic.com>
Cc:	Stephen Hemminger <shemminger@...tta.com>, netdev@...r.kernel.org,
	rdreier@...co.com, general@...ts.openfabrics.org,
	poornima.kamath@...gic.com
Subject: Re: [ofa-general] Re: [PATCH v3 08/13] QLogic VNIC: sysfs
	interface implementation for the driver

On Tue, Jun 03, 2008 at 11:55:00PM +0530, Amar Mudrankit wrote:
> Documentation/filesystems/configfs/configfs.txt <<snip>>
> 
>                   [Using configfs]
> 
>                   Like sysfs, attributes should be ASCII text files, preferably
>                   with only one value per file.  The same efficiency caveats from sysfs
>                   apply.  Don't mix more than one attribute in one attribute file.
> 
> It looks like configfs also does not allow multiple attributes per file.

But you have attribute/value pairs, right?  Just create multiple
attribute files then in configfs for them.

> So, in that case, shall we modify our sysfs code to support one value per
> sysfs file? With this approach, the impact on user space applications that
> we have which depend on the qlgc_vnic driver sysfs interface will be less.

If you want to, but as this looks like it is used for configuration, I
suggest using configfs instead.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html