netdev - Re: [PATCH net-next 2/13]bnx2x: Adding bnx2x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1212500790.18098.9.camel@lb-tlvb-eliezer.il.broadcom.com>
Date:	Tue, 03 Jun 2008 16:46:29 +0300
From:	"Eliezer Tamir" <eliezert@...adcom.com>
To:	"Eilon Greenstein" <eilong@...adcom.com>
cc:	"Andi Kleen" <andi@...stfloor.org>,
	netdev <netdev@...r.kernel.org>, jeff@...zik.org,
	davem@...emloft.net, "Michael Chan" <mchan@...adcom.com>,
	"Yaniv Rosner" <yaniv.rosner@...adcom.com>
Subject: Re: [PATCH net-next 2/13]bnx2x: Adding bnx2x_link

On Mon, 2008-06-02 at 23:31 -0700, Eilon Greenstein wrote:
> On Sun, 2008-06-01 at 22:50 +0200, Andi Kleen wrote:
...

> > > +   if (CHIP_REV_IS_FPGA(bp)) {
> >
> > Do the FPGA and IS_EMUL cases really need to be in a production
> driver?
> The support for FPGA and EMUL is part of the code in the main file as
> well. Removing it will require a patch by it self. I will prepare such
> a
> patch, but in lower priority. I agree that it has no place in the
> Kernel

IMHO, it is very much in the interest of the user that we will be able
to run on the emulation the same _exact_ driver version.

In any situation where there is an unexpected firmware event, being able
to reproduce the problem on the emulation takes us most of the way
towards figuring out what is going on.

The firmware can be very tricky to debug on the real chip.

I agree that there is room for a nice little clean-up in this area of
the code, but I would be very reluctant to have it completely removed.

Regards, 
Eliezer

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html