netdev - Re: [PATCH 1/12] BE NIC driver - Header files and initialization functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080604101133.2188c8f6@extreme>
Date:	Wed, 4 Jun 2008 10:11:33 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	"Subbu Seetharaman" <subbus@...verengines.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/12] BE NIC driver - Header files and initialization
 functions

On Wed, 04 Jun 2008 01:25:14 -0700
"Subbu Seetharaman" <subbus@...verengines.com> wrote:

> Thanks for you comments Stephen.  
> 
> We did not make MSIx the default since most testing
> was done with INTx.  Since this version of the driver does not use multiple
> interrupt vectors, there is no performance advantage in using MSIx.
> If MSIx is still the preferred default, we can change it.

MSIx isn't shared but INTx is so there is at least some gain on big systems.

> 
> NAPI makes tasklet redundant in the RX completion processing; but
> we felt deffering TX completion processing to a tasklet is a better
> idea for 10Gb data rates than doing it in hard interrupt.

Okay, other drivers do TX completion processing  in NAPI handler.
It has the advantage of rate limiting the the TX completion in case
of really high transmit load.

> I will get back soon with other comments taken care of.
> 
> Subbu
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html