netdev - Re: [PATCH] net: Fix test for VLAN TX checksum offload capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48537CA4.7040005@trash.net>
Date:	Sat, 14 Jun 2008 10:09:08 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	Stephen Hemminger <shemminger@...tta.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-net-drivers@...arflare.com
Subject: Re: [PATCH] net: Fix test for VLAN TX checksum offload capability

Ben Hutchings wrote:
> Stephen Hemminger wrote:
>> On Fri, 13 Jun 2008 23:38:16 +0100
>> Ben Hutchings <bhutchings@...arflare.com> wrote:
>>
>>> Selected device feature bits can be propagated to VLAN devices, so we
>>> can make use of TX checksum offload and TSO on VLAN-tagged packets.
>>> However, if the physical device does not do VLAN tag insertion or
>>> generic checksum offload then the test for TX checksum offload in
>>> dev_queue_xmit() will see a protocol of htons(ETH_P_8021Q) and yield
>>> false.
>> Are you sure that some hardware isn't broken and can do vlan tag
>> insertion or checksumming but not both?
> 
> The second test uses dev->features & dev->vlan_features, so this should
> be handled correctly, unless I'm missing some subtlety.

It looks fine to me.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html