netdev - Re: [PATCH] net: Fix test for VLAN TX checksum offload capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080616.170237.112856229.davem@davemloft.net>
Date:	Mon, 16 Jun 2008 17:02:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	bhutchings@...arflare.com, netdev@...r.kernel.org,
	linux-net-drivers@...arflare.com
Subject: Re: [PATCH] net: Fix test for VLAN TX checksum offload capability

From: Patrick McHardy <kaber@...sh.net>
Date: Sat, 14 Jun 2008 10:08:52 +0200

> Ben Hutchings wrote:
> > Selected device feature bits can be propagated to VLAN devices, so we
> > can make use of TX checksum offload and TSO on VLAN-tagged packets.
> > However, if the physical device does not do VLAN tag insertion or
> > generic checksum offload then the test for TX checksum offload in
> > dev_queue_xmit() will see a protocol of htons(ETH_P_8021Q) and yield
> > false.
> > 
> > This splits the checksum offload test into two functions:
> > 
> > - can_checksum_protocol() tests a given protocol against a feature bitmask
> > 
> > - dev_can_checksum() first tests the skb protocol against the device
> >   features; if that fails and the protocol is htons(ETH_P_8021Q) then
> >   it tests the encapsulated protocol against the effective device
> >   features for VLANs
> > 
> > Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> 
> Acked-by: Patrick McHardy <kaber@...sh.net>

Applied to net-2.6, thanks everyone!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html