netdev - Re: [PATCH] firmware: convert e100 driver to request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <485562F8.2000400@garzik.org>
Date:	Sun, 15 Jun 2008 14:44:08 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Jaswinder Singh <jaswinderlinux@...il.com>
CC:	David Woodhouse <dwmw2@...radead.org>, netdev@...r.kernel.org,
	e1000-devel@...ts.sourceforge.net,
	Auke Kok <auke-jan.h.kok@...el.com>
Subject: Re: [PATCH] firmware: convert e100 driver to request_firmware()

Jaswinder Singh wrote:
> Hello Jeff,
> 
> On 6/15/08, Jeff Garzik <jeff@...zik.org> wrote:
>> David Woodhouse wrote:
>>> From: Jaswinder Singh <jaswinderlinux@...il.com>
>>>
>>>  drivers/net/Kconfig                |    8 +
>>>  drivers/net/e100.c                 |  283
>>> +++++++++++-------------------------
>>>  firmware/Makefile                  |    2 +
>>>  firmware/WHENCE                    |   12 ++
>>>  firmware/e100/d101m_ucode.bin.ihex |   38 +++++
>>>  firmware/e100/d101s_ucode.bin.ihex |   38 +++++
>>>  firmware/e100/d102e_ucode.bin.ihex |   38 +++++
>>>  7 files changed, 222 insertions(+), 197 deletions(-)
>>>  create mode 100644 firmware/e100/d101m_ucode.bin.ihex
>>>  create mode 100644 firmware/e100/d101s_ucode.bin.ihex
>>>  create mode 100644 firmware/e100/d102e_ucode.bin.ihex
>> NAK - firmware should not be stored in a separate directory from the
>> driver to which it is intimately tied.
>>
> 
> driver source code will goto drivers directory and firmware will goto
> firmware directory.
> Please let us know, how can we keep them in same directory.

How?  It is simply a matter of changing the Makefile rules.

Each driver is _intimately_ tied to its firmware, so it only increases 
headaches by separating two pieces of a single, cohesive whole.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html