netdev - Re: dm9000: Remove the 2 resources probe scheme.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080615214904.GR31817@trinity.fluff.org>
Date:	Sun, 15 Jun 2008 22:49:04 +0100
From:	Ben Dooks <ben-linux@...ff.org>
To:	Bryan Wu <cooloney@...nel.org>
Cc:	Laurent Pinchart <laurentp@...-semaphore.com>,
	netdev@...r.kernel.org, Ben Dooks <ben-linux@...ff.org>
Subject: Re: dm9000: Remove the 2 resources probe scheme.

On Fri, Jun 13, 2008 at 10:29:45PM +0800, Bryan Wu wrote:
> On Fri, Jun 13, 2008 at 8:58 PM, Laurent Pinchart
> <laurentp@...-semaphore.com> wrote:
> > The dm9000 driver accepts either 2 or 3 resources to describe the platform
> > devices. The 2 resources case abuses the ioresource mechanism by passing
> > ioremap()ed memory through the platform device resources. This patch removes
> > that case and converts boards that were using it to the 3 resources scheme.
> >
> > Signed-off-by: Laurent Pinchart <laurentp@...-semaphore.com>
> > ---
> >  arch/blackfin/mach-bf527/boards/ezkit.c         |    7 ++-
> >  arch/blackfin/mach-bf533/boards/H8606.c         |    7 ++-
> >  arch/blackfin/mach-bf537/boards/generic_board.c |    7 ++-
> >  arch/blackfin/mach-bf537/boards/stamp.c         |    7 ++-
> 
> IMO, this patch can be split into two parts, one for Blackfin and the
> other for dm9000 driver.

I think I agree with that, although I would also like to make sure the
blackfin part of this is tested. I am also trying to get rid of the
defines for blackfin specific compile, as they shouldn't be in the
driver!

I've queued the dm9000 specific bits into my own little dm9000 tree
for the next kernel release.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html