| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Jun 2008 16:52:25 -0700 (PDT) From: Trent Piepho <tpiepho@...escale.com> To: Scott Wood <scottwood@...escale.com> cc: Sam Ravnborg <sam@...nborg.org>, John Rigby <jrigby@...escale.com>, linuxppc-dev@...abs.org, jeff@...zik.org, netdev@...r.kernel.org Subject: Re: [PATCH] [Rev2] MPC5121 FEC support On Tue, 17 Jun 2008, Scott Wood wrote: > Sam Ravnborg wrote: >> In general when you select a symbol that has dependencies you are almost >> always on the wrong track. > > more specific options should make sure that they never select it when the > dependencies aren't met. Sure, in theory that would work, but in practice this ends up being a constant source of broken builds. >> Use a dependency here with a sane default - then people can set it to 'n' >> if they really do not want this driver. >> >> Spreading selects too much is just causing you pain in the long run. > > I'm not sure I understand what you're looking for, but I don't see anything > wrong with something like this (apart from missing help text): > > config FS_ENET > bool > select MII > select PHYLIB > > config FS_ENET_HAS_SCC > bool "Freescale CPM SCC Ethernet" > depends on CPM1 || CPM2 > select FS_ENET What prevents me from turning on FS_ENET_HAS_SCC without MII or PHYLIB? Why is FS_ENET_HAS_SCC a bool, and not tristate? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists