netdev - Re: Fwd: [ofa-general] FW: QLogic vNIC Kernel Submission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 Jun 2008 19:59:08 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Patrick McHardy <kaber@...sh.net>
CC:	John Russo <john.russo@...gic.com>, shemminger@...tta.com,
	"Amar Mudrankit (Contractor - )" <amar.mudrankit@...gic.com>,
	netdev@...r.kernel.org, rdreier@...co.com,
	"Kuchimanchi, Ramachandra \(Contractor - \)" 
	<ramachandra.kuchimanchi@...gic.com>,
	"Poornima Kamath (Contractor - )" <poornima.kamath@...gic.com>
Subject: Re: Fwd: [ofa-general] FW: QLogic vNIC Kernel Submission

Patrick McHardy wrote:
> Frankly, you didn't even try to fix the most obvious mistakes in your
> interface, like duplication of existing interfaces (csum settings)
> and very unusual behaviour (state machine triggered device registation)
> before you started complaining (and both of these are *really* easy to
> do).
> 
> That you were asked to migrate to sysfs is unfortunate. The fact is
> though that your driver is a virtual ethernet device, not an infiniband
> device, so it should use the proper APIs for this kind of device. Work
> has been going on for years to provide a uniform interface to the network
> and your interface is a move in the opposite direction.

That's pretty much my feeling.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html