netdev - Re: [PATCH] xfrm: fix fragmentation for ipv4 xfrm tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080617044403.GA8825@gondor.apana.org.au>
Date:	Tue, 17 Jun 2008 14:44:03 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Steffen Klassert <steffen.klassert@...unet.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	klassert@...hematik.tu-chemnitz.de
Subject: Re: [PATCH] xfrm: fix fragmentation for ipv4 xfrm tunnel

On Mon, Jun 16, 2008 at 02:59:46PM +0200, Steffen Klassert wrote:
> When generating the ip header for the transformed packet
> we just copy the frag_off field of the ip header from the original packet
> to the ip header of the new generated packet. If we receive a packet
> as a chain of fragments, all but the last of the new generated packets
> have the IP_MF flag set. We have to mask the frag_off field to only
> keep the IP_DF flag from the original packet. This got lost with git commit
> 
> 36cf9acf93e8561d9faec24849e57688a81eb9c5
> [IPSEC]: Separate inner/outer mode processing on output
> 
> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>

Good catch!

Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html