netdev - Re: [PATCH] Fix corrupt TCP packets when options space overflows with MD5SIG enabled (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080618.150104.147203818.davem@davemloft.net>
Date:	Wed, 18 Jun 2008 15:01:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	agl@...erialviolet.org
Cc:	billfink@...dspring.com, netdev@...r.kernel.org
Subject: Re: [PATCH] Fix corrupt TCP packets when options space overflows
 with MD5SIG enabled (v2)

From: "Adam Langley" <agl@...erialviolet.org>
Date: Wed, 18 Jun 2008 12:39:03 -0700

> On Wed, Jun 18, 2008 at 1:52 AM, David Miller <davem@...emloft.net> wrote:
> > It's pretty easy, depending upon the timestamp resolution, to
> > end up with the original transmit and the retransmit having
> > the same timetsamp value.  So this suggestion in the RFC is
> > I think not a complete solution.
> 
> I happen to have just (unintentionally) simulated this, i.e. a
> situation where MD5 signed packets with SACKs were dropped by the
> receiving host. The transmitting host keeps sending packets with SACKs
> and they keep getting dropped: the connection stalled.

The retransmit timeout timer has to fire eventually, and when
that happens we should clear all of our SACK state.

I'm not denying your observations, I'm just stating what ought
to be happening.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html