netdev - Re: [PATCH net-next 6/8] ipv4: Check return of dev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080619.190921.177438602.davem@davemloft.net>
Date:	Thu, 19 Jun 2008 19:09:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	wangchen@...fujitsu.com
Cc:	netdev@...r.kernel.org, kaber@...sh.net
Subject: Re: [PATCH net-next 6/8] ipv4: Check return of dev_set_allmulti

From: Wang Chen <wangchen@...fujitsu.com>
Date: Fri, 20 Jun 2008 08:55:32 +0800

> @@ -435,7 +436,10 @@ static int vif_add(struct vifctl *vifc, int mrtsock)
>  	if ((in_dev = __in_dev_get_rtnl(dev)) == NULL)
>  		return -EADDRNOTAVAIL;
>  	IPV4_DEVCONF(in_dev->cnf, MC_FORWARDING)++;
> -	dev_set_allmulti(dev, +1);
> +	/* Check whether allmulti overflow */
> +	err = dev_set_allmulti(dev, 1);
> +	if (err)
> +		return err;

Please delete comment.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html