| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <485B206C.6020602@cn.fujitsu.com> Date: Fri, 20 Jun 2008 11:13:48 +0800 From: Wang Chen <wangchen@...fujitsu.com> To: David Miller <davem@...emloft.net> CC: netdev@...r.kernel.org, kaber@...sh.net Subject: Re: [PATCH net-next 6/8] ipv4: Check return of dev_set_allmulti David Miller said the following on 2008-6-20 10:09: > Please delete comment. > allmulti might overflow. Commit: "netdevice: Fix promiscuity and allmulti overflow" in net-next makes dev_set_promiscuity/allmulti return error number if overflow happened. Here, we check the positive increment for allmulti to get error return. Signed-off-by: Wang Chen <wangchen@...fujitsu.com> --- net/ipv4/ipmr.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index 11700a4..ba0280f 100644 --- a/net/ipv4/ipmr.c +++ b/net/ipv4/ipmr.c @@ -398,6 +398,7 @@ static int vif_add(struct vifctl *vifc, int mrtsock) struct vif_device *v = &vif_table[vifi]; struct net_device *dev; struct in_device *in_dev; + int err; /* Is vif busy ? */ if (VIF_EXISTS(vifi)) @@ -435,7 +436,9 @@ static int vif_add(struct vifctl *vifc, int mrtsock) if ((in_dev = __in_dev_get_rtnl(dev)) == NULL) return -EADDRNOTAVAIL; IPV4_DEVCONF(in_dev->cnf, MC_FORWARDING)++; - dev_set_allmulti(dev, +1); + err = dev_set_allmulti(dev, 1); + if (err) + return err; ip_rt_multicast_event(in_dev); /* -- 1.5.3.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists