netdev - Re: [PATCH] hfsc: add link layer overhead adaption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080623142417.9gxuu3y9r4084s4c@hayate.ip6>
Date:	Mon, 23 Jun 2008 14:24:17 +0300
From:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] hfsc: add link layer overhead adaption

Quoting Patrick McHardy <kaber@...sh.net>:

> Jussi Kivilinna wrote:
>> CBQ and HTB have options for emulating overhead of underlying link layer
>> (mpu/overhead/linklayer options). This patch makes sch_hfsc use rate table
>> to emulate link layer overhead.
>>
>> Patch uses rate table to convert packet length to emulated link layer packet
>> length using qdisc_l2t() in get_linklayer_len(). Converted packet length is
>> passed to hfsc calculations instead of real. If rate table isn't passed to
>> kernel, hfsc works as before.
>>
>> diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
>> index fdfaa3f..94fd130 100644
>> --- a/net/sched/sch_hfsc.c
>> +++ b/net/sched/sch_hfsc.c
>> +/* convert packet length to link layer packet length */
>> +static unsigned int get_linklayer_len(struct hfsc_class *cl,   
>> unsigned int len)
>> +{
>> +	u64 ll_len;
>> +	if (likely(len) && unlikely(cl->rtab)) {
>> +		ll_len = qdisc_l2t(cl->rtab, len);
>> +		if (unlikely(cl->rtab->rate.rate != PSCHED_TICKS_PER_SEC))
>> +			ll_len = div_u64(ll_len * cl->rtab->rate.rate,
>> +							PSCHED_TICKS_PER_SEC);
>> +		return (unsigned int)ll_len;
>> +	}
>> +	return len;
>> +}
>
> This looks like an abuse of rate tables, which usually convert
> packet sizes to transmission times. You undo that above using
> expensive calculations.
>
> I think this should be done by performing the length calculation
> in the kernel directly.

Yes, it's abuse, and actually table is created using false rate (rate  
= PSCHED_TICKS_PER_SEC) so div_u64 is avoided. Div_u64 is there just  
in case something goes wrong in userspace. Using rate table allows  
changes/updates to link layer emulation with only userspace updates  
avoiding, but maybe abuse of rate table isn't right way to do this  
after all.

So would it be better if I add 'length table' to kernel&userspace and  
use it instead?

  - Jussi


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html