netdev - Re: [patch v2 01/11] DM9000: Remove the 2 resources probe scheme.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200806230940.16343.laurentp@cse-semaphore.com>
Date:	Mon, 23 Jun 2008 09:40:12 +0200
From:	Laurent Pinchart <laurentp@...-semaphore.com>
To:	Ben Dooks <ben-linux@...ff.org>
Cc:	Ben Hutchings <bhutchings@...arflare.com>, netdev@...r.kernel.org,
	jeff@...zik.org
Subject: Re: [patch v2 01/11] DM9000: Remove the 2 resources probe scheme.

On Sunday 22 June 2008 23:18, Ben Dooks wrote:
> On Sun, Jun 22, 2008 at 09:34:18PM +0100, Ben Hutchings wrote:
> > Ben Dooks wrote:
> > > From: Laurent Pinchart <laurentp@...-semaphore.com>
> > > 
> > > The dm9000 driver accepts either 2 or 3 resources to describe the platform
> > > devices. The 2 resources case abuses the ioresource mechanism by passing
> > > ioremap()ed memory through the platform device resources. This patch removes
> > > that case and converts boards that were using it to the 3 resources scheme.
> > > 
> > > Signed-off-by: Ben Dooks <ben-linux@...ff.org>
> > > Signed-off-by: Laurent Pinchart <laurentp@...-semaphore.com>
> > > ---
> > > 
> > > diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
> > > index 6bc8924..fca7831 100644
> > > --- a/drivers/net/dm9000.c
> > > +++ b/drivers/net/dm9000.c
> > > @@ -528,7 +528,6 @@ dm9000_probe(struct platform_device *pdev)
> > >  	struct board_info *db;	/* Point a board information structure */
> > >  	struct net_device *ndev;
> > >  	const unsigned char *mac_src;
> > > -	unsigned long base;
> > >  	int ret = 0;
> > >  	int iosize;
> > >  	int i;
> > > @@ -561,78 +560,61 @@ dm9000_probe(struct platform_device *pdev)
> > >  	if (pdev->num_resources < 2) {
> > >  		ret = -ENODEV;
> > >  		goto out;
> > [...]
> > 
> > So shouldn't "< 2" be changed to "!= 3"?
> 
> Hmm, I'll edit laurent's patch and re-send, assuming it's alright with
> him.

That's alright with me.

-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussee de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75

Content of type "application/pgp-signature" skipped