netdev - Re: [PATCH v2 2/2] [iproute2/tc] hfsc: add link layer overhead adaption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080624225850.nvasycyghwko8k8o@hayate.ip6>
Date:	Tue, 24 Jun 2008 22:58:50 +0300
From:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
To:	lists@...yfurniss.entadsl.com
Cc:	netdev@...r.kernel.org, Patrick McHardy <kaber@...sh.net>,
	Stephen Hemminger <shemminger@...l.org>
Subject: Re: [PATCH v2 2/2] [iproute2/tc] hfsc: add link layer overhead
	adaption

Quoting Andy Furniss <lists@...yfurniss.entadsl.com>:

> Jussi Kivilinna wrote:
>> Patch adds 'mpu', 'mtu', 'overhead' and 'linklayer' options to hfsc. These
>> options are used to create size table for sch_hfsc. Size table is only used
>> and passed to kernel if these options are used.
>
>> +	unsigned short overhead = 0, mpu = 0;
>
> overhead may need to be negative because skb->len on eth is payload + 14
>
> Andy.

Ok, I made size tables use signed short for overhead instead. But this  
makes me think should htb/cfq/tfb be changed to support negative  
overhead too? Rate table they use have unsigned overhead.

  - Jussi


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html