netdev - Re: [PATCH v2 2/2] [iproute2/tc] hfsc: add link layer overhead adaption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4861698C.3040007@andyfurniss.entadsl.com>
Date:	Tue, 24 Jun 2008 22:39:24 +0100
From:	Andy Furniss <lists@...yfurniss.entadsl.com>
To:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
CC:	netdev@...r.kernel.org, Patrick McHardy <kaber@...sh.net>,
	Stephen Hemminger <shemminger@...l.org>
Subject: Re: [PATCH v2 2/2] [iproute2/tc] hfsc: add link layer overhead	adaption

Jussi Kivilinna wrote:
> Quoting Andy Furniss <lists@...yfurniss.entadsl.com>:
> 
>> Jussi Kivilinna wrote:
>>> Patch adds 'mpu', 'mtu', 'overhead' and 'linklayer' options to hfsc. 
>>> These
>>> options are used to create size table for sch_hfsc. Size table is 
>>> only used
>>> and passed to kernel if these options are used.
>>
>>> +    unsigned short overhead = 0, mpu = 0;
>>
>> overhead may need to be negative because skb->len on eth is payload + 14
>>
>> Andy.
> 
> Ok, I made size tables use signed short for overhead instead. But this 
> makes me think should htb/cfq/tfb be changed to support negative 
> overhead too? Rate table they use have unsigned overhead.

Yea they should really, somehow - eventually :-) It was discussed here -

http://news.gmane.org/find-root.php?group=gmane.linux.network&article=90386

Andy.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html