netdev - Re: [ofa-general] [PATCH] net/inet_lro: remove setting skb->ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1214397005.23583.60.camel@mtls03>
Date:	Wed, 25 Jun 2008 15:30:05 +0300
From:	Eli Cohen <eli@....mellanox.co.il>
To:	Or Gerlitz <ogerlitz@...taire.com>
Cc:	Jan-Bernd Themann <THEMANN@...ibm.com>,
	OpenFabrics General <general@...ts.openfabrics.org>,
	netdev@...r.kernel.org, Roland Dreier <rdreier@...co.com>,
	Vladimir Sokolovsky <vlad@...lanox.co.il>
Subject: Re: [ofa-general] [PATCH] net/inet_lro: remove setting
	skb->ip_summed when not LRO-able


On Wed, 2008-06-25 at 14:47 +0300, Or Gerlitz wrote:
> Jan-Bernd Themann wrote:
> > no, what I meant is that it is only not needed at that particular 
> > place as  the packet is not handled by LRO. Without this line the 
> > driver can set an individual  value for each SKB that is not 
> > aggregated if wished. For example when the packet is not a valid IP 
> > packet.  However, removing all ip_summed fields impacts the fragment 
> > lro mode. There we have to set some value for not aggregated packets. 
> > The SKBs are generated within the LRO engine. If desired (and if there 
> > is HW that wants to use that) we can pass that value for each provided 
> > fragment. This would add one additional paramter to the already 8 
> > parameters of __lro_proc_segment. That is of course possible.
> OK, understood, both points. 
> 
> Eli, lets add to this patch a comment in inet_lro.h saying that the 
> value of lro_mgr->ip_summed is ignored by the core lro code for drivers 
> that use the non fragmented mode.
We already have this comment:

struct net_lro_mgr {
	...
	u32 ip_summed;      /* Set in non generated SKBs in page mode */

I think we should use have it something like that:
	...
	/*
	 * Set for generated SKBs in that are not added to
	 * the frag list in fragmented mode
	 */
	u32 ip_summed;

What do you think?


>  Also for the ipoib patch, lets not set 
> this value.
Agree.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html