netdev - Re: [ofa-general] [PATCH] net/inet_lro: remove setting skb->ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4862419E.5040307@voltaire.com>
Date:	Wed, 25 Jun 2008 16:01:18 +0300
From:	Or Gerlitz <ogerlitz@...taire.com>
To:	eli@....mellanox.co.il
CC:	Jan-Bernd Themann <THEMANN@...ibm.com>,
	OpenFabrics General <general@...ts.openfabrics.org>,
	netdev@...r.kernel.org, Roland Dreier <rdreier@...co.com>,
	Vladimir Sokolovsky <vlad@...lanox.co.il>
Subject: Re: [ofa-general] [PATCH] net/inet_lro: remove setting	skb->ip_summed
 when not LRO-able

Eli Cohen wrote:
> We already have this comment:
> 	u32 ip_summed;      /* Set in non generated SKBs in page mode */
>
> I think we should use have it something like that:
> 	/*
> 	 * Set for generated SKBs in that are not added to
> 	 * the frag list in fragmented mode
> 	 */
> 	u32 ip_summed;
>
> What do you think?
>   
yes, this could be a little more clear.


Or

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html