netdev - RE: [PATCH] igb: completely disable interrupts during netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Jun 2008 13:29:19 -0700
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	"Andy Gospodarek" <andy@...yhouse.net>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>
Cc:	<netdev@...r.kernel.org>, <linux-pci@...r.kernel.org>
Subject: RE: [PATCH] igb: completely disable interrupts during netpoll

Andy Gospodarek wrote:
> Globally disable the interrupt during netpoll rather than simply
> disabling it on the hardware.  This will ensure all pending operations
> are complete and no more will execute.  I've seen reports of deadlocks
> with the current driver and this patch resolves them.

I agree this patch is probably okay, and if it fixes a specific problem
should be accepted however I have a question that didn't apply when we
originally created code like this.

> @@ -4024,7 +4024,7 @@ static void igb_netpoll(struct net_device
>  	*netdev) int i;
>  	int work_done = 0;
> 
> -	igb_irq_disable(adapter);
> +	disable_irq(adapter->pdev->irq);

how does changing to disable_irq/enable_irq work with MSI and MSI-X
interrupts?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html