netdev - Re: [PATCH] igb: completely disable interrupts during netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080625203931.GA32408@gospo.rdu.redhat.com>
Date:	Wed, 25 Jun 2008 16:39:31 -0400
From:	Andy Gospodarek <andy@...yhouse.net>
To:	Matthew Wilcox <matthew@....cx>
Cc:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>, netdev@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH] igb: completely disable interrupts during netpoll

On Wed, Jun 25, 2008 at 02:35:19PM -0600, Matthew Wilcox wrote:
> On Wed, Jun 25, 2008 at 01:29:19PM -0700, Brandeburg, Jesse wrote:
> > > -	igb_irq_disable(adapter);
> > > +	disable_irq(adapter->pdev->irq);
> > 
> > how does changing to disable_irq/enable_irq work with MSI and MSI-X
> > interrupts?
> 
> Works just fine.  There's a disable_irq method in the irq_chip that
> knows how to disable a particular type of interrupt.
> 

Sure does.  Just for the record, most of the other net-drivers do it
this way too.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html