netdev - Re: [PATCH 3/4] e1000: only enable TSO6 via ethtool when using correct hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48647B7B.3030805@garzik.org>
Date:	Fri, 27 Jun 2008 01:32:43 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Andy Gospodarek <andy@...yhouse.net>
CC:	netdev@...r.kernel.org, jeffrey.t.kirsher@...el.com,
	jesse.brandeburg@...el.com
Subject: Re: [PATCH 3/4] e1000: only enable TSO6 via ethtool when using correct
 hardware

Andy Gospodarek wrote:
> When enabling TSO via ethool on e1000, it is possible to set
> NETIF_F_TSO6 on hardware that does not support it.  Setting TSO via
> ethtool now matches the settings used when the hardware is probed.
> 
> Signed-off-by: Andy Gospodarek <andy@...yhouse.net>
> ---
>  drivers/net/e1000/e1000_ethtool.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000/e1000_ethtool.c
> index 701531e..a3f6a9c 100644
> --- a/drivers/net/e1000/e1000_ethtool.c
> +++ b/drivers/net/e1000/e1000_ethtool.c
> @@ -347,7 +347,7 @@ e1000_set_tso(struct net_device *netdev, u32 data)
>  	else
>  		netdev->features &= ~NETIF_F_TSO;
>  
> -	if (data)
> +	if (data && (adapter->hw.mac_type > e1000_82547_rev_2))
>  		netdev->features |= NETIF_F_TSO6;

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html