netdev - Re: [PATCH] tc35815: Fix receiver hangup on Rx FIFO overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48647BC4.90402@garzik.org>
Date:	Fri, 27 Jun 2008 01:33:56 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Atsushi Nemoto <anemo@....ocn.ne.jp>
CC:	linux-mips@...ux-mips.org, netdev@...r.kernel.org
Subject: Re: [PATCH] tc35815: Fix receiver hangup on Rx FIFO overflow

Atsushi Nemoto wrote:
> On Rx FIFO overflow error, the controller consume a buffer descriptor
> but currently the driver does not give it back to the controller.
> This results unrecoverable 'Buffer List Exhausted' condition.  This
> patch fix this problem by moving a "fbl_count--" line to proper place.
> 
> Signed-off-by: Atsushi Nemoto <anemo@....ocn.ne.jp>
> ---
> diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
> index dccea52..b07b8cb 100644
> --- a/drivers/net/tc35815.c
> +++ b/drivers/net/tc35815.c
> @@ -1736,7 +1736,6 @@ tc35815_rx(struct net_device *dev)
>  			skb = lp->rx_skbs[cur_bd].skb;
>  			prefetch(skb->data);
>  			lp->rx_skbs[cur_bd].skb = NULL;
> -			lp->fbl_count--;
>  			pci_unmap_single(lp->pci_dev,
>  					 lp->rx_skbs[cur_bd].skb_dma,
>  					 RX_BUF_SIZE, PCI_DMA_FROMDEVICE);
> @@ -1792,6 +1791,7 @@ tc35815_rx(struct net_device *dev)
>  #ifdef TC35815_USE_PACKEDBUFFER
>  			while (lp->fbl_curid != id)
>  #else
> +			lp->fbl_count--;
>  			while (lp->fbl_count < RX_BUF_NUM)
>  #endif
>  			{
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html