lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 27 Jun 2008 01:34:03 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Atsushi Nemoto <anemo@....ocn.ne.jp>
CC:	linux-mips@...ux-mips.org, netdev@...r.kernel.org
Subject: Re: [PATCH] tc35815: Mark carrier-off before starting PHY

Atsushi Nemoto wrote:
> Call netif_carrier_off() before starting PHY device.  This is a
> behavior before converting to generic PHY layer.
> 
> Signed-off-by: Atsushi Nemoto <anemo@....ocn.ne.jp>
> ---
> diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
> index 10e4e85..dccea52 100644
> --- a/drivers/net/tc35815.c
> +++ b/drivers/net/tc35815.c
> @@ -1394,6 +1394,7 @@ tc35815_open(struct net_device *dev)
>  	tc35815_chip_init(dev);
>  	spin_unlock_irq(&lp->lock);
>  
> +	netif_carrier_off(dev);
>  	/* schedule a link state check */
>  	phy_start(lp->phy_dev);
>  
> @@ -2453,6 +2454,7 @@ static int tc35815_resume(struct pci_dev *pdev)
>  		return 0;
>  	pci_set_power_state(pdev, PCI_D0);
>  	tc35815_restart(dev);
> +	netif_carrier_off(dev);
>  	if (lp->phy_dev)

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists