netdev - Re: [bug?] tg3: Failed to load firmware "tigon/tg3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Jul 2008 22:28:26 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	Theodore Tso <tytso@....edu>, Jeff Garzik <jeff@...zik.org>,
	Andi Kleen <andi@...stfloor.org>,
	David Miller <davem@...emloft.net>, hugh@...itas.com,
	akpm@...ux-foundation.org, kosaki.motohiro@...fujitsu.com,
	mchan@...adcom.com, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, netdev@...r.kernel.org
Subject: Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin"

On Fri, Jul 04, 2008 at 07:01:56PM +0100, David Woodhouse wrote:
> On Fri, 2008-07-04 at 10:30 -0400, Theodore Tso wrote:
> > So on this point I'd side with David, and say that folding "make
> > firmware_install" into "make modules_install" goes a long way towards
> > healing this particular breakage.
> 
> make modules_install | tail ...
>   INSTALL fs/nfs/nfs.ko
>   INSTALL fs/nls/nls_iso8859-1.ko
>   INSTALL fs/vfat/vfat.ko
>   MKDIR   /lib/firmware/acenic
>   INSTALL /lib/firmware/acenic/tg2.bin
>   MKDIR   /lib/firmware/tigon
>   INSTALL /lib/firmware/tigon/tg3.bin
>   INSTALL /lib/firmware/tigon/tg3_tso.bin
>   INSTALL /lib/firmware/tigon/tg3_tso5.bin
>   DEPMOD  2.6.26-rc8

I have not followed the threads about firmware - but installing
the firmware on par with modules_install seems like a good idea to me.
I gave the kbuild bits a quick look and they have my:
Acked-by: Sam Ravnborg <sam@...nborg.org>

I have yet to give all the firmware stuff a detailed review
but that will be when I get time to it.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html