netdev - Re: [PATCH] ipv[46]: Fix MD5 signatures for non-linear skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080704082402.GA16259@2ka.mipt.ru>
Date:	Fri, 4 Jul 2008 12:24:03 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Adam Langley <agl@...erialviolet.org>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] ipv[46]: Fix MD5 signatures for non-linear skbs

Hi.

On Thu, Jul 03, 2008 at 05:19:41PM -0700, Adam Langley (agl@...erialviolet.org) wrote:
> +int tcp_md5_hash_key(struct tcp_md5sig_pool *hp, struct tcp_md5sig_key *key)
> +{
> +	struct scatterlist sg;
> +
> +	sg_init_table(&sg, 1);
> +	sg_set_buf(&sg, key->key, key->keylen);
> +	return crypto_hash_update(&hp->md5_desc, &sg, key->keylen);
> +}

A trivial nit: you can use sg_init_one() to initialize single
scatterlist and set data pointer instead of sg_init_table()/sg_set_buf()
in all places where you use single sg.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html