netdev - Re: [PATCH] ipv[46]: Fix MD5 signatures for non-linear skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 7 Jul 2008 10:21:31 -0700
From:	"Adam Langley" <agl@...erialviolet.org>
To:	"Evgeniy Polyakov" <johnpol@....mipt.ru>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] ipv[46]: Fix MD5 signatures for non-linear skbs

On Fri, Jul 4, 2008 at 1:24 AM, Evgeniy Polyakov <johnpol@....mipt.ru> wrote:
> A trivial nit: you can use sg_init_one() to initialize single
> scatterlist and set data pointer instead of sg_init_table()/sg_set_buf()
> in all places where you use single sg.

Thanks both. Respun patch in a second...
Changes: Use sg_init_one where possible and take a couple of ifs out
of tcp_md5_hash_skb_data

AGL


-- 
Adam Langley agl@...erialviolet.org http://www.imperialviolet.org
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html