netdev - Re: [PATCH v3] ibm_newemac: Fixes kernel crashes when speed of cable connected changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <486E14DA.6070104@garzik.org>
Date:	Fri, 04 Jul 2008 08:17:30 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Stefan Roese <sr@...x.de>
CC:	linuxppc-dev@...abs.org, netdev@...r.kernel.org,
	benh@...nel.crashing.org, Sathya Narayanan <sathyan@...mf1.com>
Subject: Re: [PATCH v3] ibm_newemac: Fixes kernel crashes when speed of cable
 connected changes

Stefan Roese wrote:
> From: Sathya Narayanan <sathyan@...mf1.com>
> 
> The descriptor pointers were not initialized to NIL values, so it was
> poiniting to some random addresses which was completely invalid. This
> fix takes care of initializing the descriptor to NIL values and clearing
> the valid descriptors on clean ring operation.
> 
> Signed-off-by: Sathya Narayanan <sathyan@...mf1.com>
> Signed-off-by: Stefan Roese <sr@...x.de>
> ---
>  drivers/net/ibm_newemac/core.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
> index 5d2108c..ca63fa0 100644
> --- a/drivers/net/ibm_newemac/core.c
> +++ b/drivers/net/ibm_newemac/core.c
> @@ -2719,6 +2719,8 @@ static int __devinit emac_probe(struct of_device *ofdev,
>  	/* Clean rings */
>  	memset(dev->tx_desc, 0, NUM_TX_BUFF * sizeof(struct mal_descriptor));
>  	memset(dev->rx_desc, 0, NUM_RX_BUFF * sizeof(struct mal_descriptor));
> +	memset(dev->tx_skb, 0, NUM_TX_BUFF * sizeof(struct sk_buff *));
> +	memset(dev->rx_skb, 0, NUM_RX_BUFF * sizeof(struct sk_buff *));
>  

applied to 2.6.26


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html